Explicitly tell fetch in startup.js to set cookies
What does this MR do?
Explicitly tell fetch in startup.js to set cookies
fetch won’t send cookies in older browsers, unless you set the
credentials init option. We set to same-origin
which is default value
in modern browsers. See https://github.com/whatwg/fetch/pull/585 for
more information.
See: !26386 (merged)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert