Skip to content

Revert justified-content-end in admin, group, & project settings

Taurie Davis requested to merge 246783-setting-button-position into master

What does this MR do?

Fixes positioning of buttons in admin, group, and project settings.

Related MR: gitlab-org/gitlab-services/design.gitlab.com!2083 (merged) Related issue: gitlab-design#1019 (closed)

before after
Screen_Shot_2020-09-15_at_7.57.41_AM Screen_Shot_2020-09-15_at_7.58.33_AM
Screen_Shot_2020-09-15_at_7.56.35_AM Screen_Shot_2020-09-15_at_7.59.55_AM

Note: The screenshots above represent a subset of the changes. This MR updates the buttons within all the settings subsections found within projects, groups, and admin area.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #246783 (closed)

Edited by Taurie Davis

Merge request reports

Loading