Make SSH keys publicly accessible
What does this MR do?
- Reverts !35507 (merged).
-
!35507 (merged) moved
get
SSH keys from keys controller to user controller to reduce confusion between gpg keys and ssh keys, but since the User controller goes through the permission policy to read user, a non-logged in user would get redirected to the log in page if they tried to go tohttps://gitlab.example.com/username.keys
- More in-depth discussion here: #235756 (comment 396156444)
-
!35507 (merged) moved
- Adds RSpecs to
keys_controller_spec.rb
to ensure that when signed out, user's SSH public keys are stillget
table.
Screenshots
Incognito browser (so not signed in) still shows SSH keys:
% curl http://127.0.0.1:3000/root.keys
ssh-rsa AAAA...gJw0= Administrator (127.0.0.1)%
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #235756 (closed)
Edited by Serena Fang