DAST on-demand site profiles: prevent error banner from showing
What does this MR do?
This MR puts a feature flag before a request to prevent an error-banner from showing due to accessing a non-existing Graphql endpoint.
How to test this?
- Make sure the the feature flag is disabled (it should be by-default):
echo "Feature.disable(:security_on_demand_scans_site_validation)" | rails c-
Navigate to the DAST Site profile form in your GDK and create a new profile:
/:namespace/:project/-/on_demand_scans/profiles/dast_site_profiles/new -
Once you are back on the profiles-listing page click the
editbutton for your newly created profile -
The form should now load pre populated and without any error banners showing
Screenshots
| before | after |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #249439 (closed)
Edited by David Pisek