Fix legacy filter bar parameters
What does this MR do?
I think we missed updating one more spot for the code review analytics filters in !41121 (merged).
- This MR updates the parameters to match the values expected in
filters/setFilters
- Adds an additional spec
Note: this occurs in the legacy filter bar, so the code_review_analytics_has_new_search
must be disabled to reproduce. This filter bar will eventually be replaced with a vue implementation.
Current behvaiour
- Navigate to
/gitlab-org/gitlab/-/analytics/code_reviews
- Apply a milestone or label filter
- Nothing changes in the results
Testing
- Navigate to
/gitlab-org/gitlab/-/analytics/code_reviews
- Apply a milestone or label filter
- The results should be filtered
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #212682 (closed)
Edited by Ezekiel Kigbo