Fix MR Modal Vulnerability Links Overflow Modal
What does this MR do?
This MR fixes that the links [and identifiers] in the vulnerability modal (used in the pipeline security page) can overflow the modal. It is fixed by adding the gl-word-break-all
CSS class to both places.
It is unlikely that an identifier will overflow though.
Relates to #242035 (closed).
Steps to test
- Open a pipeline which found vulnerabilities.
- Open a vulnerability in the
Security
tab which has a link [or identifier] that contains a lot of alphanumeric characters without any other characters (e.g. a SHA256 hash). If you don't have a vulnerability with such a link, you can either create one or go the lazy way and simulate it by replacing thelinks
computed value with the following snippet:
links() {
return [
{
url:
'https://gitlab.com/gitlab-examples/security/security-reports/-/commit/f34619f924ba08039cf3932853695b8cae737ef1f34619f924ba08039cf3932853695b8cae737ef1',
},
];
// return this.asNonEmptyListOrNull(this.vulnerability.links);
},
- Check that the link overflows the modal.
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
-
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev