WIP: Avoid localhost as Elasticsearch default
What does this MR do?
The current recommendation within our Elasticsearch integration document is to install Elasticsearch on a separate host from the host on which GitLab is installed. There are several places within the code, including the Elasticsearch URL Setting Helper that currently include examples which points to localhost or which default to http://localhost:9200. This suggests to administrators that localhost (the GitLab server) is the default place to put Elasticsearch and can lead to poorly provisioned search infrastructure.
This change adjusts those examples to use host1 and host2 instead of localhost to match what is described in the GitLab Elasticsearch configuration documentation or to remove the default so that http://localhost:9200 is not assumed.
Screenshots
The Elasticsearch intergrations settings screen with examples using http://localhost:9200.
The documentation of installing Elasticsearch with warning about localhost.
The documentation of the URL field in the Elasticsearch settings.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team