Skip to content

Web IDE: Remove property `binary` on the file object.

Himanshu Kapoor requested to merge 222512-binary into master

What does this MR do?

Issue: #222512 (closed)

We can get rid of the binary property on the file object. We can use an existing utility function isTextFile to determine whether it is a text file or binary when necessary.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports

Loading