Skip to content

Network policy editor fixes

Arthur Evstifeev requested to merge network-policy-editor-fixes into master

What does this MR do?

This MR fixes several issues in network builder found during QA, specifically:

  1. yaml mode's content is not updated on mode switch if there is a yaml parse error
  2. Updated label and input styles to be closer to mocks
before after mock
Screenshot_2020-09-16_Policy_editor___Administrator_cilium-test_2_ Screenshot_2020-09-16_Policy_editor___Administrator_cilium-test_1_ mock
  1. Improved error state in rule mode, brings it closer to the mock
before after mock
Screenshot_2020-09-16_Policy_editor___Administrator_cilium-test_3_ Screenshot_2020-09-16_Policy_editor___Administrator_cilium-test_5_ mock

related to #247958 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mark Florian

Merge request reports

Loading