Skip to content

Extract cycle analytics page specific CSS

Lukas Eipert requested to merge epic-3694-page-specific-ee-bundles into master

What does this MR do?

This MR moves the cycle_analytics.scss page-specific CSS into a page bundle as per &3694

The primary intention is to establish a pattern to show how one would extract a page specific CSS bundle with a separate EE version

Unfortunately, we need to refactor our page specific bundles a little bit in order to ensure that EE versions of page-specific CSS bundles are preferred over the CE versions while still allowing a fallback if not in EE. To achieve this we introduce a little helper method as well in order to be a bit more verbose and show where the CSS files are coming from.

Caveat: Some colors have been changed.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jean du Plessis

Merge request reports

Loading