Fix(Analytics Filter Bars): ensure correct queries
What does this MR do?
This MR fixes an issue where the query parameters where not the right format. This is a quick fix. A better fix would be to create a getter for the filter store module. I created a ticket to follow up on this here: #250328
I don't believe a changelog is needed, since this has not been released, yet.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
Feature flags that need to be enabled for testing:
- Value Stream Analytics:
value_stream_analytics_path_navigation
andvalue_stream_analytics_filter_bar
- Code Review Analytics:
code_review_analytics_has_new_search
- Merge Request Analytics:
project_merge_request_analytics
Run the following script SEED_CYCLE_ANALYTICS=true bundle exec rake db:seed_fu FILTER=cycle_analytics
and navigate here, to see the Value Stream Analytics page:
It is hard to get the charts to actually show, but an easy way to test that it fixes the problem is that it will return the right queries in the getter here: https://gitlab.com/gitlab-org/gitlab/-/blob/249591-mlunoe-fix-getter-data-structure-for-filter/ee/app/assets/javascripts/analytics/cycle_analytics/store/getters.js#L42
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #249591 (closed)