Skip to content

Don't include mr_notes store on issue page

Simon Knox requested to merge psi-issue-no-diff into master

What does this MR do?

Cut some unused code from issue page, for a 32% filesize saving!

sidebar_bundle was importing both notes/store and mr_notes/store. The latter includes tree_worker, which is pretty big.

Screenshots

Before After
Screen_Shot_2020-09-17_at_5.38.19_pm Screen_Shot_2020-09-17_at_5.52.06_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading