Skip to content

Split sign in and sign up pages

Nicolas Dular requested to merge nicolasdular/split-signin-and-signup into master

What does this MR do?

Part of gitlab-org/growth/engineering#64 (closed)

Instead of using tabs to switch between the sign and sign up pages, we wanna have two different pages. This is part of an experiment that was already rolled out on gitlab.com.

This does not remove the signup_experiment completely yet since it's still used to determine if "confirmation" should be skipped for sign up which I would like to tackle in a separate MR.

Screenshots

Sign in

Before After After with LDAP
Screenshot_2020-09-18_at_13.28.20 Screenshot_2020-09-18_at_13.27.07 Screenshot_2020-10-15_at_17.11.20

Sign up

Before After
Screenshot_2020-09-18_at_13.28.22 Screenshot_2020-09-18_at_13.26.25

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular

Merge request reports

Loading