Skip to content

Use gl-icon component for alert system notes

What does this MR do?

Addresses this discussion !35902 (comment 375427915)

Suggestion (non-blocking): Using v-html always comes with a bit of a security consideration. I think we may have the same effect using <gl-icon>:

<gl-icon v-if="iconName" :name="iconName" />

Screenshots

Before After
Screen_Shot_2020-09-17_at_17.38.28 Screen_Shot_2020-09-18_at_17.06.40

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

References #227321 (closed)

Edited by Olena Horal-Koretska

Merge request reports

Loading