Skip to content

Add clearer message to test failure

Dan Davison requested to merge dj-add-better-failure-description-for-unfinished-requests into master

What does this MR do?

Provide an appropriate failure message when a QA test fails due to an infinite spinner as seen from #250691 (closed) .

This failure message will also present itself if an asynchronous request takes too long.

Before

Failures:

  1) Create Create a new merge request creates a basic merge request
     Failure/Error: expect(merge_request).to have_description(merge_request_description)
     
     QA::Support::Repeater::WaitExceededError:
       Wait condition not met after 60 seconds

After

Failures:

  1) Create Create a new merge request creates a basic merge request
     Failure/Error: expect(merge_request).to have_description(merge_request_description)
     
     QA::Support::Repeater::WaitExceededError:
       Page did not fully load. This could be due to an unending async request or loading icon.

Does this MR meet the acceptance criteria?

Conformity

Edited by Dan Davison

Merge request reports