Skip to content

Normalize empty params in ActionCable logging

What does this MR do?

Related to gitlab-com/gl-infra/delivery#1210 (comment 414925769)

Lograge's ActionCable subscriber sets the method, path, and format to empty hashes in https://github.com/roidrage/lograge/blob/v0.11.2/lib/lograge/log_subscribers/action_cable.rb#L14-L16.

We transform these to empty strings so that the data type will be consistent.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports

Loading