Skip to content

Refactor Project/Group import missing author note

What does this MR do?

While working on #212298 (closed) I noticed that this part of the code could be a bit improved.

  • Removes duplicated admin? check. This validation is already done in Gitlab::ImportExport::MembersMapper.
  • Remove some accessory methods, making the conditional more explicit.
  • Use String template to manipulate the note itself.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports

Loading