Skip to content

Auto-accept TOS for project access token bots

Serena Fang requested to merge pat-bot-terms into master

What does this MR do?

Previously, project bots had to accept the Terms of Service when their admin enforced TOS. This creates a 403 Forbidden error since project bots can't access GitLab from a web browser and a workaround requires access to the Rails console. This MR auto-accepts the TOS for project bots so that project access tokens can be used as intended.

Auto-acceptance of TOS shouldn't be problem since we're capturing the id of whoever created the bot, so any TOS abuse responsibility would fall upon the creator.

Closes #225222 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Serena Fang

Merge request reports

Loading