Skip to content

Remove internal fields from alert details table

Tristan Read requested to merge tr-filter-internal-strings into master

What does this MR do?

The alert detail table shows internal alert fields. This is because it displays anything that was returned from the AlertManagementAlert api call.

These additional fields are used for other functionality on the page, so cannot be removed from the query. Instead, we should filter the alert data to show only desired fields in the table.

Changes:

  • add a filter for desired alert detail fields to the table component.
  • remove filtering from usage of this table in the incident page, since this functionality is now performed by the alert detail table component.

issue: #225651 (closed)

Screenshots

before after
Screen_Shot_2020-09-23_at_16.42.48-fullpage Screen_Shot_2020-09-23_at_17.34.09-fullpage

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports

Loading