Skip to content

Delete the .netrc file created during a QA test

Mark Lapierre requested to merge ml-delete-netrc-after-test into master

What does this MR do?

A couple of tests were failing authentication after project_archive_compare_spec added two users to the .netrc file.

This is a workaround that removes the .netrc file after project_archive_compare_spec so that subsequent tests won't use the wrong credentials.

However, a better solution would be to make it simpler to test pushing to different URLs as the same user (QA::Git::Repository does all of its file system work in a temp directory that's created each time perform is called. We use a .netrc file stored in a temp directory named after the process id so that we can test pushing to primary and secondary nodes in Geo tests using the same user) https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/670

See:

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mark Lapierre

Merge request reports

Loading