Skip to content

Remove bootstrap usage from merge_requests/invalid

Alexander Turinske requested to merge 233674-remove-bootstrap-usage-invalid into master

What does this MR do?

Remove bootstrap usage from merge_requests/invalid

- app/views/projects/merge_requests/invalid.html.haml
- update text color

To reproduce

  1. create an MR
  2. Update the following file
--- a/app/controllers/projects/merge_requests_controller.rb
+++ b/app/controllers/projects/merge_requests_controller.rb
     respond_to do |format|
       format.html do
         # use next to appease Rubocop
-        next render('invalid') if target_branch_missing?
+        next render('invalid')

Screenshots

Before After
Screen_Shot_2020-09-25_at_11.07.50_AM Screen_Shot_2020-09-25_at_11.15.28_AM Screen_Shot_2020-09-25_at_11.15.16_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #233674 (closed)

Related to gitlab-com/www-gitlab-com#8498 (closed)

Edited by Alexander Turinske

Merge request reports

Loading