Skip to content

Group members Vue conversion - date fields

What does this MR do?

Part of &4233 (closed)

Behind the vue_group_members_list feature flag. To enable:

  1. bin/rails console
  2. Feature.enable(:vue_group_members_list)

As part of the effort to convert the group members view from HAML to Vue this MR adds the date related fields to the members table. It adds Access granted, Access expires, Invited, and Requested fields. To keep MRs small the rest of the table will come in a series of subsequent MRs.

Review App

https://gitlab-review-238459-con-d9ywna.gitlab-review.app/groups/gitlab-instance-3fa80b9a/-/group_members

Screenshots

Desktop

Screen_Shot_2020-09-25_at_1.17.37_PM

Mobile

Screen_Shot_2020-09-25_at_1.18.31_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading