Skip to content

Optimize and refactor ConfigService and GeneratedConfig

Chad Woolley requested to merge sse-config-refactor-grpc-calls into master

What does this MR do?

Various cleanup, refactoring, and performance optimizations in ConfigService and GeneratedConfig.

Tasks

  • Remove unnecessary usage of constants (this is a documented anti-pattern, see https://docs.gitlab.com/ee/development/performance.html#moving-allocations-to-constants)
  • Ensure GRPC calls are optimized and not duplicated. NOTE: There weren't any changes needed for this, the three existing GRPC calls (commit, markdown file blob, config file blob data) are all independent and necessary.
  • Remove unnecessary nil checks of required values (for example, ref)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related Issues/MRs

Edited by Mayra Cabrera

Merge request reports

Loading