Fallback to matching policy on license name
What does this MR do?
This change fixes a defect that occurs when self managed installations do not have outbound network access to fetch the latest SPDX catalogue. When this occurs, the software_licenses
table contains a nil
value in the spdx_identifier
column for each row in the table.
The change in this MR allows for falling back to matching policy with license based on license name when an spdx identifier for the software license is not available.
This change also fixes the following QA tests:
-
gitlab-org/quality/testcases#575 (closed) -
gitlab-org/quality/testcases#964 (closed) -
gitlab-org/quality/testcases#963 (closed) -
gitlab-org/quality/testcases#965 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by mo khan