Skip to content

Scope css pipeline graph rules to the pipelines show page

Miguel Rincon requested to merge 239861-scope-graph-pipeline-show-page-css into master

What does this MR do?

Part of #239861 (closed)

Scope css rules to the pipelines show page

Scope pipeline graph CSS rules to a single page via a selector for the page: projects:pipelines:show, so they can be later moved to an individual pipeline page (projects:pipelines:show).

The following selectors have moved:

  • .pipeline-tab-content Pipelines tab in the page.
  • .pipeline-graph Pipelines full graph view
  • .dropdown-counter-badge Used in parallel jobs.

This change helps scope them only to that page while the rules are moved.

Screenshots

Related view if a simple pipeline, no changes are expected:

image

When the pipeline has upstream/downstream pipelines

image

image

For parallel jobs:

Screen_Shot_2020-09-30_at_3.57.03_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports

Loading