Skip to content

Fix LDAP group settings heading being shown when feature disabled

Drew Blessing requested to merge dblessing_ldap_sync_view_conditional into master

What does this MR do?

Fixes a heading being visible when the feature itself is disabled. This resulted in the heading being displayed without any content. This also changes the case of the heading to match the existing style in the page, and our style guides (in a heading, words after the first should not be camel case).

Screenshots

Before

Screen_Shot_2020-09-30_at_12.40.35_PM

After

Screen_Shot_2020-09-30_at_12.40.06_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Drew Blessing

Merge request reports

Loading