Fix search sorting issue
What does this MR do?
During the testing of !43295 (merged) on staging we noticed that sort doesn't work for all scopes. Turns out that we forgot to pass sort
parameter to some classes.
This MR fixes this problem and adds specs to catch similar type of errors in the future.
This feature is not user facing, so I believe we don't need a changelog here.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #255322 (closed)
Edited by Dmitry Gruzd