Skip to content

On-demand loading of select2 CSS

Tim Zallmann requested to merge tz-load-select2-on-demand into master

What does this MR do?

The target of this MR is to reduce the overall CSS size significantly as all CSS for select2 is only loaded when we actually have select2 elements on screen.

  • Added all select2 relevant CSS in a Lazy bundle already in a previous MR
  • Now the select2 css is removed from the main css bundle in this MR
  • The Lazy CSS Bundle for select2 is loaded through a JS function
  • All the JS changes are simply the wrapping of the loading function
  • Spec changes are around adding additional waits for the CSS being loaded

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tim Zallmann

Merge request reports

Loading