Fix cached queries for Groups::GroupMembersController#index
What does this MR do?
As listed in epic: &3873 (closed), we detected several end-points that have a big amount of CACHE
SQL. This is one of them.
We were executing group.has_owner(current_user) for each group member while rendering the list. This is the cause of big number of cached queries.
This MR fixes this issue, by checking if current_user
is a group owner only once.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #231468 (closed)
Edited by Justin Ho Tuan Duong