Skip to content

Maintenance mode displays a banner message

Aakriti Gupta requested to merge ag-block-non-get-http-in-read-only-mode into master

What does this MR do?

This MR adds a banner message when the instance is in maintenance mode.

No changelog required here since this feature is behind a feature flag.

We might want to wait on merging this until the actual changes are in that will make the instance read-only.

For now only an initial review is needed. Please don't pass to a maintainer yet.

Here is the expected output when multiple conditions hold for showing banners. For now we have decided to stack them up. *Some of the screenshots follow:

Case Maintenance mode DB read only(read-only instance) Secondary Message
1* true true true secondary + maintenance mode
2* true true false read-only instance + maintenance mode
3. true false true can't happen
4* true false false maintenance mode
5. false true true secondary, as before
6. false true false read-only instance, as before
7. false false true can't happen
8. false false false no banner

Related issue: #217893 (closed)

Screenshots

Case 1

case_1

Case 2

case_2

Case 4

Default banner

Screenshot_2020-10-21_at_17.18.25

User set banner message

Screenshot_2020-10-21_at_17.20.11

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Aakriti Gupta

Merge request reports

Loading