Follow-up from "GraphQL: Create board list with milestone or assignee"
What does this MR do?
From the issue
It seems odd to first find all milestones, then perform this check later. Can we move this into the finder class instead? If we were to filter by milestone ID earlier (i.e. in the finder), then here we could simply test for whether the result was empty.
It would also make for better SRP since SQL belongs in the finders not the controllers.
After looking at this again, I think in general it's structured correctly. We grab a Finder, which returns a relation, and then narrow the scope a little further. I was able to get rid of the direct ActiveRecord calls and use real scopes, so we're able to remove some of the rubocop: disable CodeReuse/ActiveRecord lines.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #242039