Skip to content

Fix CI config graph with only one stage

What does this MR do?

When there was only on stage in the CI config, the white background had only one of the 2 corners rounded which looked weird. This has been fixed by using a method that determine which class to apply based on the index.

Feature is still behind a feature flag, so no changelog required.

I was wondering if it was worth adding a test for the new method, but it's really just a string returned based on index and so I feel the test would either be useless or it would cover the function but only check the internals of the components, and not what it actually looks like and so I didn't add any.

Screenshots

Before

Screen_Shot_2020-10-15_at_10.32.49_AM

After

Screen_Shot_2020-10-15_at_10.32.27_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Frédéric Caplette

Merge request reports

Loading