Skip to content

Remove unnecessary labels css

Coung Ngo requested to merge cngo-remove-unnecessary-labels-css into master

What does this MR do?

This MR removes unnecessary labels css. There is css for the group, project, admin and milestone labels pages that is either no longer used or unnecessary.

The only change was moving the bottom margin for .prioritized-labels from the SCSS stylesheet to a utility class in Haml, so otherwise there are no visual changes.

Screenshots

section before after
group labels page Screenshot_2020-10-15_Labels___Gitlab_Org aScreenshot_2020-10-15_Labels___Gitlab_Org
project labels page Screenshot_2020-10-15_Labels___Gitlab_Org_Gitlab_Test aScreenshot_2020-10-15_Labels___Gitlab_Org_Gitlab_Test
admin labels page Screenshot_2020-10-15_Labels___Admin_Area aScreenshot_2020-10-15_Labels___Admin_Area
milestone show page Screenshot_2020-10-15_Sprint_-_Eos_quis_placeat_rem_qui_quibusdam___Milestones___Gitlab_Org_Gitlab_Test aScreenshot_2020-10-15_Sprint_-_Eos_quis_placeat_rem_qui_quibusdam___Milestones___Gitlab_Org_Gitlab_Test

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports

Loading