Skip to content

Fix the soft_fail_count_by_state feature flag

Nick Thomas requested to merge fix-soft-fail-count-by-state-ff into master

What does this MR do?

IssuableFinder may be used in project or group contexts. While adding a feature flag, I assumed we could use parent to pick either, but it doesn't work.

A feature flag was just added directly above my own, which uses params.group || params.project. I've verified locally (the tests customarily just check blanket en/disablement) that this incantation works as expected.

No need for a changelog, since this is just an inability to selectively turn on a feature flag that isn't documented.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nick Thomas

Merge request reports

Loading