Revert "Merge branch '206929-fix-workflow-rules-variable-access' into 'master'"
What does this MR do?
Reverts !44935 (merged).
This causes production incident creating double-pipelines. Since it moves workflow rules evaluation after validating job dependencies it makes the system to persist an error, as being a first in a sequence of operations.
This can be triggered by this example:
workflow:
rules:
- if: $MY_FLAG
rspec:
script: echo Hello World
stage: test
rules:
- if: $MY_FLAG
coverage:
stage: deploy
script: echo HW
needs:
- rspec
Since the rspec:
would be created only if MY_FLAG
would be set to true, this will instead produce
an failed pipeline, since we will evaluate coverage:
dependency before rejecting the pipeline by workflow:rules:
.
Related to !44935 (merged)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński (Back 2025-01-01)