Skip to content

Uses non-feature-gated GitLab team member check for gitlab_service_user?

James Johnson requested to merge d0c-s4vage-ungate_gitlab_team_member_check into master

What does this MR do?

This MR changes the gitlab_service_user? function to use a non-feature-gated check to see if the service user belongs to GitLab.

!45310 (merged) implemented the gitlab_service_user? check, but the check to see if the user belonged to GitLab was feature-gated by the :gitlab_employee_badge feature flag.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading