Skip to content

Replace bootstrap classes for alerts in ping consent

Alexander Turinske requested to merge 233669-remove-bootstrap-ping into master

What does this MR do?

Replace bootstrap classes with gitlab ui

  • for ping consent alert

How to reproduce

  1. Implement the diff below
diff --git a/app/views/shared/_ping_consent.html.haml b/app/views/shared/_ping_consent.html.haml
index d9c03a5eaff..b41d38dc128 100644
--- a/app/views/shared/_ping_consent.html.haml
+++ b/app/views/shared/_ping_consent.html.haml
@@ -1,4 +1,4 @@
-- if session[:ask_for_usage_stats_consent]
+- unless session[:ask_for_usage_stats_consent]
  1. Navigate to a project

Screenshots (strongly suggested)

Before After
Screen_Shot_2020-10-20_at_3.30.21_PM image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #233669 (closed)

Related to gitlab-com/www-gitlab-com#8498 (closed)

Edited by Alexander Turinske

Merge request reports

Loading