Skip to content

Remove the native styles for modal-dialog - Currently off center

Jarek Ostrowski requested to merge fix-modal-margins into master

What does this MR do?

Fixes the top and bottom margins of our modal-dialog, currently it's significantly off center.

With gitlab-ui!1717 (merged) we added styles to center the modal, which included a x and y margin style. Currently on gitlab.com, we are setting the modal-dialog margin styles, which should be removed in favor the latest css changes in gitlab-ui so our modals are centered as intended.

Screenshots (strongly suggested)

Before After
Screen_Shot_2020-10-21_at_11.20.50_AM Screen_Shot_2020-10-21_at_11.17.17_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jarek Ostrowski

Merge request reports

Loading