Reset the search filters upon a scope change
What does this MR do?
This MR ensures the search filters are reset whenever the search scope is changed using the tabs.
By removing these parameters from the list (which are non-generic), each search link created by this helper will remove these parameters. This is specifically why I changed the name to be SEARCH_GENERIC_PARAMS. With this MR, only the parameters that are relevant across all scopes will be kept around when changing the scope.
See it this way: if the parameters are brought along, that means the "state" filter from Issue and Merge Request would persist while changing scope, when it actually means two different things.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Close to #258209 (closed)