Skip to content

Resolve IP address from RequestContext for audit

Tan Le requested to merge 239305-resolve-ip-address-for-audit into master

What does this MR do?

Resolve IP address from RequestContext for audit event.

Before this MR, to correctly instrument audit event, the callers have to pass on the request IP address. These classes do not always have access to IP address (e.g. Service classes). In addition, acquiring this piece of information should not be the responsibility of the callers.

In this MR, we push the responsibility to resolve IP address to the AuditEventService. IP address can be retrieved from RequestContext and injected directly on AuditEventService. This approach helps keeping the interface to AuditEventService smaller and be more user-friendly.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #239305 (closed)

Edited by Tan Le

Merge request reports

Loading