Refactor(profile preferences): integration views
What does this MR do?
This MR refactors the integration views of the profile/preferences page from HAML to Vue as a stepping stone to achieving these goals:
The final piece will be to move the form to submit in Vue so that we can remove this file: profiles/preferences/update.js.erb
- MR 1: This one
- MR 2: !49032 (closed)
- MR 3: !48805 (closed)
Screenshots (strongly suggested)
Before | After |
---|---|
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
To test this out:
- Navigate to http://localhost:3000/admin/application_settings/general and scroll to "Gitpod"
- The link to https://gitpod.io should still work and look the same!
- Choose whether you want "gitpod" enabled by clicking "expand" and checking/unchecking the box (see screenshots above).
- Then, navigate to http://localhost:3000/profile/preferences and scroll to the bottom.
- If you checked Gitpod it should show up here
- I was never able to get Sourcegraph to show up, but I removed the
if
-statment here to get it to show up: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/helpers/preferences_helper.rb#L86
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #259621
Edited by Michael Lunøe