Improve remaining work metrics for deleted objects worker
What does this MR do?
Ci::DeleteObjectsWorker
uses LimitedCapacityWorker for scheduling and concurrency settings. LimitedCapacityWorker
reports remaining_work_count
metric to Prometheus when the job completes. With remaining_capacity
as an upper limit to the count we can't see if there's more work to be done than there is available capacity.
For example, with Ci::DeleteObjectsWorker
running at full capacity, the metric would be always 1
because there is only one capacity slot available(the job that it's currently executing).
Related to #247103 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Marius Bobin