Migrate to GlTooltipDirective in Web IDE components/mr_file_icon.vue
What does this MR do?
- For &1079 (closed) >> &973
- For technical-writing#215 (closed)
- Replace
tooltip
withGlTooltipDirective
inapp/assets/javascripts/ide/components/mr_file_icon.vue
Closes #229017 (closed)
Screenshots (strongly suggested)
Seems the migration made it buggy:
BEFORE | AFTER |
---|---|
tooltip-part-of-mr-button-before | tooltip-part-of-mr-button |
How to get there:
- Open and edit a file, submit an MR through the Web IDE.
- From the IDE, click the branch name / MR button to open the drop-down.
- Click Merge Requests to check out the MR.
- Click on your MR. GitLab will refresh and open the Review tab.
- Go to the file tree and hover over the file you'd changed.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Marcia Ramos