Skip to content

Bug fix for writing SAST_DEFAULT_ANALYZERS with SAST Config UI

rossfuhrman requested to merge 260331-sast-default-analyzers-bug into master

What does this MR do?

Addresses the problem described in #260331 (closed)

We were assuming that the list of analyzers would be provided in the same order as the SAST_DEFAULT_ANALYZERS constant, but this wasn't the case, causing the equality comparison to fail. To address this, we are now sorting the SAST_DEFAULT_ANALYZERS constant as well as the list of provided analyzers.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #260331 (closed)

Edited by Saikat Sarkar

Merge request reports

Loading