Skip to content

Enable host check for webpack-dev-server

Mike Greiling requested to merge mg-enable-webpack-host-check into master

What does this MR do?

Removes the disableHostCheck option for webpack-dev-server.

Note: This will currently break websocket connections when webpack-dev-server has a different hostname from the GDK rails hostname. I am opening a separate MR for gitlab-development-kit which will set webpack's hostname to match by default and produce a warning when they do not match.

Screenshots (strongly suggested)

n/a

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading