Move pipelines list to GraphQL - Part 1
What does this MR do?
This is the first MR in a series of MR's to complete a larger effort.
What is that effort? We are moving the Pipelines List feature of our product over to GraphQL. To safely do this we are going to introduce this refactor behind a feature flag (:graphql_pipelines_list
). We are also going to tackle some technical debt in this area. Some of that technical debt includes events, homegrown polling and a homegrown store.
The approach is to create small copies of components within app/assets/javascripts/pipelines/components/pipelines_list/pipelines.vue
with the suffix new
and make changes as the MR's proceed to complete the refactor. Those changes will handle the new data structure we receive as well as remove the technical debt I was discussing earlier.
Will it all work right away? No it won't, that' would be quite the effort and a huge MR to review. But we will be able to introduce these MRs into the codebase safely while behind the flag :graphql_pipelines_list
What does this MR do?
- Introduces
:graphql_pipelines_list
- Setups Apollo and a Query
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team