Skip to content

Realign DAST site validation frontend with backend

Paul Gascou-Vaillancourt requested to merge fix-dast-site-validation into master

What does this MR do?

Re #233020 (comment 438461945)

This addresses a few discrepancies between the frontend and the backend for DAST Site Validation.

How to test this?

  1. Enable the feature flag:
echo "Feature.enable(:security_on_demand_scans_site_validation)" | rails c
  1. In a project, open the New site profile form (/:group/:project/-/security/configuration/dast_profiles/dast_site_profiles/new.

  2. Fill-in the profile's target URL and enable the Validate target site toggle.

Screenshots (strongly suggested)

Before After
Screen_Shot_2020-10-29_at_3.02.14_PM Screen_Shot_2020-10-29_at_3.01.13_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading