Skip to content

Global Search - Left Sidebar

Zack Cuddy requested to merge 241691-left-side-facets into master

What does this MR do?

Closes #241691 (closed)

This change creates a search facet sidebar for the issues and merge requests view. This will be the location we use in the future to add more search facets.

This change moves the Status and Confidential filter over to the facets and converts them to Radio Buttons from the Dropdown they were before.

These filters also do not auto apply, and instead they require an apply button to be pressed. This allowed us to remove a lot of logic from the filters themselves.

Screenshots (strongly suggested)

Desktop View

Issues Merge Requests
Desktop View Screen_Shot_2020-11-05_at_11.09.12_AM Screen_Shot_2020-11-05_at_11.10.05_AM

Reset Filters

No Filter Filter
Reset Filters Screen_Shot_2020-11-05_at_11.09.12_AM Screen_Shot_2020-11-05_at_11.11.49_AM

Smaller Views

Medium (Tablet) Mobile
Smaller Views Screen_Shot_2020-11-05_at_11.09.42_AM Mobile
Other Views (Unchanged)
Before After
Projects Projects__Before_ Projects__After_
Milestones Milestones__Before_ Milestones__After_
Comments Comments__Before_ Comments__After_
Code Code__Before_ Code__After_
Commit Commit__Before_ Commit__After_
Wiki Wiki__Before_ Wiki__After_
Users Users__Before_ Users__After_

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #241691 (closed)

Edited by Zack Cuddy

Merge request reports

Loading