Skip to content

Add "skipped" status to deployments

David Barr requested to merge davebarr/gitlab:37947-skipped-deployments into master

What does this MR do?

Currently, deployments can have a status of: created, running, success, failed, or canceled. This MR adds a new status of skipped, to resolve the bug identified in #37947 (closed), and avoids Deployments::LinkMergeRequestWorker and Deployments::ExecuteHooksWorker for this new status.

Screenshots (strongly suggested)

Before Feature.enable(:cd_skipped_deployment_status):

prod environment index page:

prod environment index page

Webhook received:

Webhook received

After Feature.enable(:cd_skipped_deployment_status):

prod environment index page remains unchanged as per above screenshot.

No webhook received.

Database contains new deployment tuple with new skipped status, but doesn't appear on UI:

Database rows

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #37947 (closed)

Edited by David Barr

Merge request reports

Loading