Skip to content

Add message in CI linter that it was validated with includes

What does this MR do?

Add more information after linting to show users that their configuration has been linted with all the includes that are listed in the configuration. There is a feature flag ci_lint_vue that has a new vue section. Therefore to make this change, I updated it in both places and when we get rid of the flag, we'll simply remove the whole haml section.

Screenshots (strongly suggested)

Before

With ci_lint_vue feature flag turned off

Screen_Shot_2020-11-02_at_3.20.42_PM

Screen_Shot_2020-11-02_at_3.20.16_PM

With ci_lint_vue feature flag turned on

Screen_Shot_2020-11-02_at_3.21.31_PM

Screen_Shot_2020-11-02_at_3.21.41_PM

After

With ci_lint_vue feature flag turned off

Screen_Shot_2020-11-04_at_11.21.45_AM

Screen_Shot_2020-11-04_at_11.21.56_AM

With ci_lint_vue feature flag turned on

Screen_Shot_2020-11-04_at_11.27.30_AM

Screen_Shot_2020-11-04_at_11.27.40_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273434 (closed)

Edited by Frédéric Caplette

Merge request reports

Loading